Add STARK batching #388
Add STARK batching #388
Conversation
github-actions
bot
added
the
crate: evm_arithmetization
| // Add lookup columns. | ||
| let lookups = stark.lookups(); | ||
| let mut res = { | ||
| let mut columns = Vec::new(); |
There was a problem hiding this comment.
| let mut columns = Vec::new(); | |
| let mut columns = Vec::with_capacity(lookups.len() * config.num_challenges); |
There was a problem hiding this comment.
There are more columns than that, since the number of lookup columns depend on the individual lookups. I don't think computing it just for the capacity is worth it?
There was a problem hiding this comment.
yeah it's a lower bound, but it avoids all intermediary allocations. Right now we're starting with a capacity of 4.
evm_arithmetization/src/prover.rs
Outdated
| let mut degree_bits_squashed = Table::all_degree_logs().to_vec(); | ||
| degree_bits_squashed.dedup(); |
There was a problem hiding this comment.
We need a slice as argument for prove_openings so I decided to go with a vec directly.
evm_arithmetization/src/prover.rs
Outdated
| let trace_poly_values_sorted: [_; NUM_TABLES] = Table::all_sorted() | ||
| .iter() | ||
| .map(|&table| trace_poly_values[*table].clone()) | ||
| .collect::<Vec<_>>() | ||
| .try_into() | ||
| .unwrap(); | ||
|
|
||
| // We compute the Field Merkle Tree of all STARK traces. | ||
| let trace_polys_values_sorted_flat: Vec<_> = trace_poly_values_sorted | ||
| .clone() | ||
| .into_iter() | ||
| .flatten() | ||
| .collect(); | ||
| let num_trace_polys = trace_polys_values_sorted_flat.len(); |
There was a problem hiding this comment.
Same here, the clones are way too heavy
There was a problem hiding this comment.
These clones are a bit trickier to remove, but I got rid of the other two sections.
evm_arithmetization/src/prover.rs
Outdated
| pub fn zkevm_fast_config() -> StarkConfig { | ||
| let cap_height = 4; | ||
| let mut strategy = Vec::new(); | ||
| for window in Table::all_degree_logs().windows(2) { | ||
| if window[0] != window[1] { | ||
| strategy.push(window[0] - window[1]); | ||
| } | ||
| } |
There was a problem hiding this comment.
How do you intend to have it work with dynamic batching? The config must be known for preprocessing
There was a problem hiding this comment.
Hmm, good point. I guess the easiest way would be to add a BatchedStark strategy to compute this dynamically.
Nashtare
force-pushed
the
stark_batching_continuations
branch
from
097e324
to
f44f9a4
Compare
Replaces #366.
This one is targeting
feat/continuationsinstead ofdevelop.